Fix that partial insert with nulls may result in negative inserted point count#17640
Merged
jt2594838 merged 2 commits intoMay 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a partial insert has failed measurements (\measurements[i] == null), the \pointsInserted\ counter could go negative in two paths:
**\AbstractMemTable.insertAlignedRow**: a failed measurement slot has both \measurements[i] == null\ and values[i] == null. The old guard \if (values[i] == null)\ did not check \measurements[i]\ first, so the null value was counted as a
ullPoint\ and subtracted from the total, producing a negative result.
**\AbstractMemTable.computeTabletNullPointsNumber**: failed measurement columns were not skipped before inspecting their bitmaps, so any marked bits in a failed column were incorrectly counted as null points.
Changes
ullPointsNumber.
Tests